Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP version doesn't run end-to-end tests since monorepo split #134

Open
ciaranmcnulty opened this issue Jan 5, 2023 · 4 comments · May be fixed by #135
Open

PHP version doesn't run end-to-end tests since monorepo split #134

ciaranmcnulty opened this issue Jan 5, 2023 · 4 comments · May be fixed by #135
Assignees
@ciaranmcnulty

Comments

@ciaranmcnulty
Copy link
Contributor

ciaranmcnulty commented Jan 5, 2023 •
edited

(spotted in #102)

The PHP implementation used to look at the compatibility-kit folder to get the ndjson example files.

Because of the way this was implemented, a non-existent folder = no source data = skipped tests :/

The Ruby version also uses the CCK to test, but it looks like CCK is published as a bundle and data's sourced from there - the PHP implementation should explicitly download the CCK data and use it for the tests.
@ciaranmcnulty ciaranmcnulty self-assigned this Jan 5, 2023
@ciaranmcnulty
Copy link
Contributor Author

@mpkorstanje am I right in thinking the Java version doesn't have any end-to-end tests in this repo? Should we add some?

@ciaranmcnulty ciaranmcnulty changed the title PHP version doesn't run acceptance tests since monorepo split PHP version doesn't run end-to-end tests since monorepo split Jan 5, 2023
@ciaranmcnulty
Copy link
Contributor Author

#110 is related

@mpkorstanje
Copy link
Contributor

Java has end to end tests. But they're intentionally limited to some interesting cases.

https://github.com/cucumber/messages/blob/main/java/src/test/java/io/cucumber/messages/NdjsonSerializationTest.java

@ciaranmcnulty
Copy link
Contributor Author

OK I'll do some temporary thing to ensure the CCK samples are downloaded during build, then we can remove that if and when #110 happens

@ciaranmcnulty ciaranmcnulty linked a pull request Jan 6, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciaranmcnulty ciaranmcnulty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit CCK download to make PHP acceptance tests run ciaranmcnulty/messages
2 participants
@ciaranmcnulty @mpkorstanje