added support for Attachments (aka Embedddings) #623
+218
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The cucumber and events formatters support the inclusion of Attachments.
The proposed API is demonstrated in the tests as ...
⚡️ What's your motivation?
#617
Want support for Attachments from steps.
This PR proposes to use the context.Context object as a means to attach content from the step.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
This change involves minimal changes to patterns of use of godog API's.
I added tests for the cuke and events formats but the coverage isn't being recorded even on some lines I didn't modify.
fmt_output_test.go now has a normalise() fn that eliminates some extraneous diffs in the actual/expected files such as line endings and also line numbers so that the tests are easier to maintain and cross platform,
📋 Checklist: