Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from golint to staticcheck #457

Merged
merged 16 commits into from
Feb 15, 2022
Merged

Switch from golint to staticcheck #457

merged 16 commits into from
Feb 15, 2022

Commits on Feb 10, 2022

  1. Switch from golint to staticcheck

    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    0bed6e1 View commit details
    Browse the repository at this point in the history

  2. Remove unused function 

    run_test.go:618:6: func passingStepDefWithoutReturn is unused (U1000)
    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    90856a8 View commit details
    Browse the repository at this point in the history

  3. Remove unused function 

    suite.go:421:6: func isEmptyFeature is unused (U1000)
    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    51b43f4 View commit details
    Browse the repository at this point in the history

  4. Fix unnecessary use of fmt.Sprintf 

    test_context_test.go:45:66: unnecessary use of fmt.Sprintf (S1039)
test_context_test.go:46:61: unnecessary use of fmt.Sprintf (S1039)
    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    8e1c1a3 View commit details
    Browse the repository at this point in the history

  5. Fix CI error 

    https://github.com/cucumber/godog/runs/5146601108?check_suite_focus=true#step:7:28
    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    ca7d545 View commit details
    Browse the repository at this point in the history

  6. Change CI to run staticcheck instead of golint

    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    04aa1a4 View commit details
    Browse the repository at this point in the history

  7. Use staticcheck that definitely pass

    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    dd60b1a View commit details
    Browse the repository at this point in the history

  8. Fix CI staticcheck error 

    https://github.com/cucumber/godog/runs/5147133955?check_suite_focus=true#step:6:17
    @carleeto
    carleeto committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    c0e5527 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into switch-from-golint-to-staticcheck

    @mattwynne
    mattwynne committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    129f122 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Only run staticcheck for Go 1.17 

    Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
    @carleeto @vearutop
    carleeto and vearutop committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    9896794 View commit details
    Browse the repository at this point in the history

  2. Add staticcheck linux binary

    @carleeto
    carleeto committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    ed31677 View commit details
    Browse the repository at this point in the history

  3. Update Go module dependencies in _examples

    @carleeto
    carleeto committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    d2b7c4b View commit details
    Browse the repository at this point in the history

  4. Use static check binary in bin for CI

    @carleeto
    carleeto committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    1523a48 View commit details
    Browse the repository at this point in the history

  5. Reduce number of dependencies 

    Also add a note to CONTRIBUTING.md about the _examples module
    @carleeto
    carleeto committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    9c1d196 View commit details
    Browse the repository at this point in the history

  6. Pin the version of staticcheck 

    Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
    @carleeto @vearutop
    carleeto and vearutop committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    534ab13 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Merge branch 'main' into switch-from-golint-to-staticcheck

    @mattwynne
    mattwynne committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    8594a6c View commit details
    Browse the repository at this point in the history