Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WSL friendly check-go-version setup #443

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Add WSL friendly check-go-version setup #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9035e04
Add WSL friendly check-go-version setup
mxygem Nov 30, 2021
15f21af
Add changelog entry and update my username
mxygem Nov 30, 2021
290cefa
Add PR link to changelog
mxygem Nov 30, 2021
bff4443
Stop it saying 'noting to be done for check-go-version'
mattwynne Nov 30, 2021
390a064
Update CHANGELOG.md
mxygem Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 13 additions & 7 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

---

## [Unreleased]

### Fixed

- `check-go-version` in Makefile to run on WSL. ([443](https://github.com/cucumber/godog/pull/443) - [mxygem])

## [v0.12.2]

### Fixed
Expand Down Expand Up @@ -146,8 +152,8 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

### Changed

- Run godog features in CircleCI in strict mode ([jaysonesmith])
- Removed TestMain call in `suite_test.go` for CI. ([jaysonesmith])
- Run godog features in CircleCI in strict mode ([mxygem])
- Removed TestMain call in `suite_test.go` for CI. ([mxygem])
- Migrated to [gherkin-go - v11.0.0](https://github.com/cucumber/gherkin-go/releases/tag/v11.0.0). ([240](https://github.com/cucumber/godog/pull/240) - [lonnblad])

### Deprecated
Expand All @@ -158,7 +164,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

- Fixed the time attributes in the JUnit formatter. ([232](https://github.com/cucumber/godog/pull/232) - [lonnblad])
- Re enable custom formatters. ([238](https://github.com/cucumber/godog/pull/238) - [ericmcbride])
- Added back suite_test.go ([jaysonesmith])
- Added back suite_test.go ([mxygem])
- Normalise module paths for use on Windows ([242](https://github.com/cucumber/godog/pull/242) - [gjtaylor])
- Fixed panic in indenting function `s` ([247](https://github.com/cucumber/godog/pull/247) - [titouanfreville])
- Fixed wrong version in API example ([263](https://github.com/cucumber/godog/pull/263) - [denis-trofimov])
Expand All @@ -181,18 +187,18 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
### Fixed

- Find/Replaced references to DATA-DOG/godog -> cucumber/godog for docs. ([209](https://github.com/cucumber/godog/pull/209) - [smikulcik])
- Fixed missing links in changelog to be correctly included! ([jaysonesmith])
- Fixed missing links in changelog to be correctly included! ([mxygem])

## [0.8.0]

### Added

- Added initial CircleCI config. ([jaysonesmith])
- Added initial CircleCI config. ([mxygem])
- Added concurrency support for JUnit formatting ([lonnblad])

### Changed

- Changed code references to DATA-DOG/godog to cucumber/godog to help get things building correctly. ([jaysonesmith])
- Changed code references to DATA-DOG/godog to cucumber/godog to help get things building correctly. ([mxygem])

### Deprecated

Expand All @@ -214,7 +220,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
<!-- Contributors -->

[axw]: https://github.com/axw
[jaysonesmith]: https://github.com/jaysonesmith
[mxygem]: https://github.com/mxygem
[lonnblad]: https://github.com/lonnblad
[smikulcik]: https://github.com/smikulcik
[ericmcbride]: https://github.com/ericmcbride
Expand Down
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

VERS := $(shell grep 'const Version' -m 1 godog.go | awk -F\" '{print $$2}')

FOUND_GO_VERSION := $(shell go version)
EXPECTED_GO_VERSION = 1.17
.PHONY: check-go-version
check-go-version:
@[[ "$(shell go version)" =~ $(EXPECTED_GO_VERSION) ]] || (echo Wrong go version! Please install $(EXPECTED_GO_VERSION) && exit 1)
@$(if $(findstring ${EXPECTED_GO_VERSION}, ${FOUND_GO_VERSION}),(exit 0),(echo Wrong go version! Please install ${EXPECTED_GO_VERSION}; exit 1))

test: check-go-version
@echo "running all tests"
Expand Down