New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WSL friendly check-go-version setup #443
Conversation
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 81.58% 81.58%
=======================================
Files 26 26
Lines 2177 2177
=======================================
Hits 1776 1776
Misses 308 308
Partials 93 93 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me both in WSL Ubuntu 20.04 and macos.
Nice work @mxygem! The only nit-pick I have with this is that I see this in my terminal:
I think that last commit has fixed that. Can you check it still works on WSL? |
Co-authored-by: Viacheslav Poturaev <vearutop@gmail.com>
Yea! Nice job. That error shouldn't happen when versions match when |
Description
I've written a new version check that jives with WSL. I haven't tested this against macOS or other envs, so if others could help with that, I'd appreciate it!
Motivation & context
Currently folks utilizing WSL are unable to run
make test
as execution of the version check fails.Type of change
Checklist: