Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade geckodriver-helper #389

Merged
merged 1 commit into from
May 17, 2018
Merged

Conversation

xtrasimplicity
Copy link
Member

@xtrasimplicity xtrasimplicity commented May 17, 2018

Summary

Following on from #370, @radar's improvements to geckodriver-helper were merged upstream and released as version 0.20.1, so I've upgraded the appraisals to match ~> 0.20.2 (the newest release as of today) rather than ~> 0.0.5.

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This change is Reviewable

olleolleolle
olleolleolle previously approved these changes May 17, 2018
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green!

@xtrasimplicity
Copy link
Member Author

xtrasimplicity commented May 17, 2018

@olleolleolle Just waiting for Travis to finish. :) There's a 90%+ chance it'll be fine, given it's pretty much all passing on Ruby 2.2.9, but I'd rather wait. I can see that the codeship build has finished, but I don't seem to have access to view the results. :/

@olleolleolle
Copy link
Contributor

I had some "banner vision" re: only 1 of the badges is actually Travis.

@olleolleolle olleolleolle dismissed their stale review May 17, 2018 08:11

I looked at the wrong thing, and the CI is not yet visibly green

@xtrasimplicity
Copy link
Member Author

All good! 😀

@xtrasimplicity xtrasimplicity merged commit 4e072c3 into master May 17, 2018
@xtrasimplicity xtrasimplicity deleted the xtrasimplicity-patch-1 branch May 17, 2018 08:25
@luke-hill
Copy link
Contributor

For ref, webdrivers will manage all path requirements (Not just gecko), if you wanted something more robust. Also exporting the path is possible in travis and would be easier than using a gem?

@xtrasimplicity
Copy link
Member Author

@luke-hill Thanks so much for the suggestion - it sounds great! I'll check it out when I get a moment. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants