Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factory_girl renamed to factory_bot #386

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cucumber-rails.gemspec
Expand Up @@ -26,7 +26,7 @@ Gem::Specification.new do |s|
s.add_development_dependency('bundler', '>= 1.3.5')
s.add_development_dependency('selenium-webdriver', '>= 3.4.1')
s.add_development_dependency('database_cleaner', '>= 1.0.0')
s.add_development_dependency('factory_girl', '>= 3.2')
s.add_development_dependency('factory_bot', '>= 3.2')
s.add_development_dependency('rake', '>= 0.9.2.2')
s.add_development_dependency('rspec', '~> 3.0')
s.add_development_dependency('rails')
Expand Down
8 changes: 4 additions & 4 deletions features/emulate_javascript.feature
Expand Up @@ -16,12 +16,12 @@ Feature: Emulate Javascript
And I write to "features/step_definitions/s.rb" with:
"""
Given /^there is a widget named "([^"]*)"$/ do |name|
FactoryGirl.create(:widget, name: name)
FactoryBot.create(:widget, name: name)
end
"""
And I write to "features/support/factories.rb" with:
"""
FactoryGirl.define do
FactoryBot.define do
factory :widget do
name 'testwidget'
end
Expand Down Expand Up @@ -73,12 +73,12 @@ Feature: Emulate Javascript
And I write to "features/step_definitions/s.rb" with:
"""
Given /^there is a widget named "([^"]*)"$/ do |name|
FactoryGirl.create(:widget, name: name)
FactoryBot.create(:widget, name: name)
end
"""
And I write to "features/support/factories.rb" with:
"""
FactoryGirl.define do
FactoryBot.define do
factory :widget do
name 'testwidget'
end
Expand Down
6 changes: 3 additions & 3 deletions features/step_definitions/cucumber_rails_steps.rb
Expand Up @@ -27,7 +27,7 @@ def install_cucumber_rails(*options)
gem 'geckodriver-helper', group: :test
gem 'rspec-rails', group: :test
gem 'database_cleaner', group: :test unless options.include?(:no_database_cleaner)
gem 'factory_girl', group: :test unless options.include?(:no_factory_girl)
gem 'factory_bot', group: :test unless options.include?(:no_factory_bot)
# Newer versions of rake remove a method used by RSpec older versions
# See https://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11#35893625
if Gem::Version.new(RSpec::Support::Version::STRING) < Gem::Version.new('3.4.4')
Expand Down Expand Up @@ -78,14 +78,14 @@ def fixture(path)

Given /^I have created a new Rails app with no database and installed cucumber-rails$/ do
rails_new args: '--skip-active-record'
install_cucumber_rails :no_database_cleaner, :no_factory_girl
install_cucumber_rails :no_database_cleaner, :no_factory_bot
overwrite_file('features/support/env.rb', "require 'cucumber/rails'\n")
create_web_steps
end

Given /^I have created a new Rails app "(.*?)" with no database and installed cucumber\-rails$/ do |app_name|
rails_new name: app_name, args: '--skip-active-record'
install_cucumber_rails :no_database_cleaner, :no_factory_girl
install_cucumber_rails :no_database_cleaner, :no_factory_bot
overwrite_file('features/support/env.rb', "require 'cucumber/rails'\n")
create_web_steps
end
Expand Down