Disable display of detailed exceptions #296
Conversation
pedrosmmoreira
force-pushed
the
disable_detailed_exceptions
branch
from
a917f40
to
75ed39d
Compare
|
@pedrosmmoreira thank you for the PR, but the tests are not passing. Can you please try and get them to pass first? |
|
@Kosmas Absolutely, I'm working on it :) |
|
@Kosmas This PR depends on |
|
@pedrosmmoreira thanks for having a look. I think it would make sense to have a check for the rails version, and then depending on > or < 3.2.1 set the show_detailed_exceptions. What do you think? |
|
@pedrosmmoreira would you like to try again now that the tests are fixed? |
|
@Kosmas Sure, I'll rebase and check if we can clear this. |
|
@pedrosmmoreira can you please rebase so it can run again. |
pedrosmmoreira
force-pushed
the
disable_detailed_exceptions
branch
from
53cdc72
to
9f9ea02
Compare
|
@Kosmas Done. Sorry for the delay on this. |
|
@pedrosmmoreira no worries.. we had some problems with the tests anyway, but let's see if they work now! |
pedrosmmoreira
force-pushed
the
disable_detailed_exceptions
branch
from
9f9ea02
to
8afbd08
Compare
|
@pedrosmmoreira can you rebase with master to make sure all tests passes? |
`@allow-rescue` permits rescuing exceptions by setting `action_dispatch.show_exceptions` to true in the env hash. However, this will render the detailed error page and not the public error page you'd encounter in production. Given that the feature enables testing of error pages, and seems to be intended to mirror production behaviour as per the comment on https://github.com/cucumber/cucumber-rails/blob/master/lib/generators/cucumber/install/templates/support/_rails_each_run.rb.erb#L6-L14, this PR sets `action_dispatch.show_detailed_exceptions` to false, thus enabling the public error page to be rendered.
There are slight changes in the error message displayed in the public error pages across Rails versions. Checking for "We're sorry, but something went wrong." seems to be the safest option.
This PR depends on action_dispatch.show_detailed_exceptions being set, which was only introduced in Rails 3.2.1. Here we introduce a conditional check based on the required Rails version in order to ensure backwards compatibility.
pedrosmmoreira
force-pushed
the
disable_detailed_exceptions
branch
from
8afbd08
to
a090efc
Compare
|
@mathieujobin All done - I'm currently traveling but I'll look to see if we can this ready for merge as soon as I am back. Apologies for leaving it neglected so long! |
|
I've rebased these changes onto master, and have created a new PR (#387). I'll close this one off. |
@allow-rescuepermits rescuing exceptions by settingaction_dispatch.show_exceptionsto true in the env hash. However, this will render the detailed error page and not the public error page you'd encounter in production.Given that the feature enables testing of error pages, and seems to be intended to mirror production behaviour as per the comment on https://github.com/cucumber/cucumber-rails/blob/master/lib/generators/cucumber/install/templates/support/_rails_each_run.rb.erb#L6-L14, this PR sets
action_dispatch.show_detailed_exceptionsto false, thus enabling the public error page to be rendered.