[Rebased] Disable display of detailed exceptions #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@allow-rescue` permits rescuing exceptions by setting `action_dispatch.show_exceptions` to true in the env hash. However, this will render the detailed error page and not the public error page you'd encounter in production. Given that the feature enables testing of error pages, and seems to be intended to mirror production behaviour as per the comment on https://github.com/cucumber/cucumber-rails/blob/master/lib/generators/cucumber/install/templates/support/_rails_each_run.rb.erb#L6-L14, this PR sets `action_dispatch.show_detailed_exceptions` to false, thus enabling the public error page to be rendered.
There are slight changes in the error message displayed in the public error pages across Rails versions. Checking for "We're sorry, but something went wrong." seems to be the safest option.
This PR depends on action_dispatch.show_detailed_exceptions being set, which was only introduced in Rails 3.2.1. Here we introduce a conditional check based on the required Rails version in order to ensure backwards compatibility.
xtrasimplicity
changed the title
As we don't support Rails 3 in Cucumber-rails >= 1.5
olleolleolle
approved these changes
Apr 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the same as #296 (PR), but has been rebased onto the latest changes to master. The following summary is copied from the other PR.
@allow-rescuepermits rescuing exceptions by settingaction_dispatch.show_exceptionsto true in the env hash. However, this will render the detailed error page and not the public error page you'd encounter in production.Given that the feature enables testing of error pages, and seems to be intended to mirror production behaviour as per the comment on https://github.com/cucumber/cucumber-rails/blob/master/lib/generators/cucumber/install/templates/support/_rails_each_run.rb.erb#L6-L14, this PR sets
action_dispatch.show_detailed_exceptionsto false, thus enabling the public error page to be rendered.How Has This Been Tested?
The
allow_rescuefeature has been extended to verify the content of the error page.Types of changes
Checklist:
This change is