Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove --add-plugin alternate name from USAGE.txt #2319

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

ebreck
Copy link
Contributor

@ebreck ebreck commented Jun 18, 2021

--add-plugin is no longer a valid synonym for --plugin; it was removed in 839dba7 . But the USAGE still listed it as a synonym.

--add-plugin is no longer a valid synonym for --plugin; it was removed in cucumber@839dba7 .  But the USAGE still listed it as a synonym.
@mpkorstanje mpkorstanje changed the title Remove --add-plugin alternate name from USAGE.txt [Core] Remove --add-plugin alternate name from USAGE.txt Jun 18, 2021
@mpkorstanje mpkorstanje added the 🐛 bug Defect / Bug label Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2319 (3ef079d) into main (b73b38b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2319   +/-   ##
=========================================
  Coverage     83.36%   83.36%           
  Complexity     2320     2320           
=========================================
  Files           300      300           
  Lines          8272     8272           
  Branches        750      750           
=========================================
  Hits           6896     6896           
  Misses         1079     1079           
  Partials        297      297           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73b38b...3ef079d. Read the comment docs.

@mpkorstanje mpkorstanje merged commit fac96a1 into cucumber:main Jun 18, 2021
@aslakhellesoy
Copy link
Contributor

Hi @ebreck,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers!

mpkorstanje pushed a commit that referenced this pull request Aug 5, 2021
`--add-plugin` is no longer a valid synonym for `--plugin`; it was removed in
839dba7.  But the USAGE still listed it
as a synonym.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants