Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve appveyor build: Specs part #618

Merged
merged 20 commits into from May 19, 2019
Merged

Improve appveyor build: Specs part #618

merged 20 commits into from May 19, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented May 18, 2019

Summary

Work towards a green build on AppVeyor for just the specs

Details

  • Build on supported Ruby versions
  • Run only the spec part of the test suite
  • Fix specs

Motivation and Context

I want to get at least part of #505 merged but the cucumber part is tough.

How Has This Been Tested?

Specs have been run on Linux, AppVeyor will check Windows.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

mvz added 20 commits May 18, 2019 19:35
@mvz
Build on recent Rubies in AppVeyor
6c04131
@mvz
Run only the RSpec part of the test suite on appveyor
43dea0c
@mvz
Wrap long lines
e002b4b
@mvz
Remove trailing blank space
e08caa4
@mvz
Make command_runtime_environment blank by default
0e5b7ba 
The existing default is not needed, since ENV is always used as a base
for the local environment.
@mvz
Clean up environment variable handling
8349b62 
- Use inject on all versions of Ruby, not need to make a distinction
  here.
- Clean up overrides in WindowsEnvironmentVariables
- Override to_h in WindowsEnvironmentVariables so it correctly upcases
  ENV values.
@mvz
Remove parameters with defaults
e57c468 
SpawnProcess should work without specifying these, and there are no
specs that essentially override these defaults.
@mvz
Replace ENV.to_hash with platform-specific code
500ce53
@mvz
Simplify specs for stderr handling
9b78d1b 
Instead of setting up or using a shell script, just use Ruby with a
script on the command line.
@mvz
Test command and arguments for SpawnProcess
2633b0b
@mvz
Clean up spec for ChildProcess launch error
cc48232 
This splits the specs in a Unix and Windows versions, just like for the
specs for commands with spaces.
@mvz
Unify preparations for specs for SpawnProcess#start
3ea6dd0
@mvz
Add specs for #to_s for command string classes
70f0a93
@mvz
Properly escape command and arguments on windows
82db73a
@mvz
Remove #to_s from CommandString classes
bdf6368 
This method basically returns one of the initializer arguments so makes
little sense.
@mvz
Replace match? to support older Rubies
12fb604
@mvz
Allow any line ending
0a775b9
@mvz
Make spec pass with Windows' read-only permissions
fc76f31
@mvz
Skip permission scenarios on Windows
216fe02
@mvz
Use correct path separator in RSpec setup
2f0d91b
@mvz
Copy link
Contributor Author

mvz commented May 18, 2019

I've started with my part of #505 and will cherry-pick some of the other commits as needed. After this is done, I'll rebase what remains of #505.

@mvz mvz merged commit 816e6c1 into master May 19, 2019
@mvz mvz deleted the improve-appveyor-build-specs branch May 19, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mvz