Deprecate file creation when using append_to_file #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
issue-726-deprecate-file-creation-when-appending
branch
from
bc43ca4
to
db3c021
Compare
olleolleolle
approved these changes
Jan 24, 2021
luke-hill
approved these changes
Jan 25, 2021
| @@ -26,7 +26,7 @@ Feature: Append content to file | |||
| When I run `cucumber` | |||
| Then the features should all pass | |||
|
|
|||
| Scenario: Append to a non-existing file | |||
| Scenario: Append to a non-existing file (deprecated) | |||
There was a problem hiding this comment.
Question (not a sticking point)
Is this the format we'll be doing in features for deprecated stuff? We can copy to other repos if desired.
There was a problem hiding this comment.
I think it's clear this way, but maybe there are other options.
mvz
force-pushed
the
issue-726-deprecate-file-creation-when-appending
branch
from
db3c021
to
9298b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecate file creation when using
#append_to_fileDetails
This change makes
#append_to_filecheck if the file exists. If it does not, a deprecation message is shown and the file is created. In Aruba 2.0, the deprecated behavior will be removed.Motivation and Context
The #append_to_file method creates the file if it does not exist. In such cases, #create_file should be used instead.
See #726.
How Has This Been Tested?
The relevant cucumber scenario has been amended to check for the presence of the deprecation message.
Types of changes
Checklist: