Merge pull request #781 from cucumber/issue-726-deprecate-file-creati…

…on-when-appending

Deprecate file creation when using append_to_file

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.8.1.
+# using RuboCop version 1.9.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -56,7 +56,7 @@ Metrics/MethodLength:
 
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 193
+  Max: 198
 
 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
@@ -194,7 +194,7 @@ Style/Documentation:
     - 'lib/aruba/setup.rb'
     - 'lib/aruba/tasks/docker_helpers.rb'
 
-# Configuration parameters: MaxUnannotatedPlaceholdersAllowed.
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   EnforcedStyle: unannotated

features/03_testing_frameworks/cucumber/steps/filesystem/append_to_file.feature

@@ -1,6 +1,6 @@
 Feature: Append content to file
 
-  You might want to append some content to a file.
+  You might want to append some content to an existing file.
 
   Background:
     Given I use a fixture named "cli-app"
@@ -48,7 +48,7 @@ Feature: Append content to file
     When I run `cucumber`
     Then the features should all pass
 
-  Scenario: Append to a non-existing file
+  Scenario: Append to a non-existing file (deprecated)
     Given a file named "features/non-existence.feature" with:
     """
     Feature: Existence
@@ -65,3 +65,7 @@ Feature: Append content to file
     """
     When I run `cucumber`
     Then the features should all pass
+    And the output should contain:
+    """
+    The ability to call #append_to_file with a file that does not exist is deprecated
+    """

lib/aruba/api/filesystem.rb

@@ -326,7 +326,12 @@ def chmod(*args)
       def append_to_file(file_name, file_content)
         file_name = expand_path(file_name)
 
-        Aruba.platform.mkdir(File.dirname(file_name))
+        unless File.exist? file_name
+          Aruba.platform.deprecated("The ability to call #append_to_file with a file that" \
+                                    " does not exist is deprecated and will be removed in" \
+                                    " Aruba 2.0.")
+          Aruba.platform.mkdir(File.dirname(file_name))
+        end
         File.open(file_name, "a") { |f| f << file_content }
       end