Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support SSL keys in .env files as multiline text #2072

Merged
merged 2 commits into from Feb 16, 2021
Merged

feat: support SSL keys in .env files as multiline text #2072

merged 2 commits into from Feb 16, 2021

Conversation

ovr
Copy link
Member

@ovr ovr commented Feb 11, 2021 •
edited

Hello!

For #2010

Thanks

@ovr ovr requested a review from a team as a code owner February 11, 2021 22:28
@ovr ovr requested a review from hassankhan February 11, 2021 22:29
@ovr ovr mentioned this pull request Feb 11, 2021
Merged
@hassankhan hassankhan self-assigned this Feb 12, 2021
@ovr ovr force-pushed the dotenv-multiline branch 2 times, most recently from 9c16150 to 5dc3e35 Compare February 16, 2021 15:57
hassankhan
hassankhan approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@hassankhan hassankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovr Works like a charm 👍

@hassankhan hassankhan added the enhancement New feature proposal label Feb 16, 2021
@hassankhan hassankhan added this to In progress in Roadmap 2021 Q1 via automation Feb 16, 2021
@hassankhan hassankhan self-requested a review February 16, 2021 16:45
@ovr ovr merged commit d9f5154 into master Feb 16, 2021
Roadmap 2021 Q1 automation moved this from In progress to Done Feb 16, 2021
@ovr ovr deleted the dotenv-multiline branch February 16, 2021 16:51
@hassankhan hassankhan mentioned this pull request Feb 16, 2021
Closed
igorlukanin pushed a commit that referenced this pull request Feb 16, 2021
@ovr @igorlukanin
feat: support SSL ca/cert/key in .env files as multiline text (#2072)
b330807 
* feat: support SSL keys in .env files as multiline text

* fix: read file to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassankhan hassankhan hassankhan approved these changes

Assignees

@hassankhan hassankhan

Labels
enhancement New feature proposal
Projects
No open projects
Roadmap 2021 Q1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ovr @hassankhan