Adds Ruby 3.0, 3.1, and 3.2 to CI #982
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwl
added a commit
to drwl/annotaterb
that referenced
this pull request
May 23, 2023
Pulled from ctran/annotate_models#982. Credit to @petergoldstein.
BryanH
approved these changes
Dec 11, 2023
BryanH
approved these changes
Dec 11, 2023
Removes obsolete and unused gems. Replaces use of unmaintained files gem to allow running under Ruby 3.2.
petergoldstein
force-pushed
the
feature/add_ruby_3_2_to_ci
branch
from
ca75fdd
to
ac92cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned into a bit bigger of a PR than I originally anticipated, because a number of the gems in the Gemfile were either unmaintained or no longer applicable and had not been cleaned up. Required changes to get everything running included:
activerecordconstraint in the Gemfile to allow versions '< 8'ruby_dep,codeclimate-test-reporter,coveralls, andtravisgems because they are no longer applicable and have compatibility issues with recent Rubies.filesgem and replacing the functionality in the specs, because it is unmaintained and its use ofFile.exists?is not compatible with Ruby 3.2Additional changes include:
rubocopandrubocop-rspecversions in the Gemfile[]onENVwithfetchENVloads given the changes in 2.This runs green on my fork.