Support --frozen option for routing annotations
#979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg8m
force-pushed
the
support-routing-frozen
branch
2 times, most recently
from
1205cb8
to
66ce208
Compare
|
@kg8m Would you mind rebase against the latest Thanks. |
ctran
reviewed
Mar 29, 2023
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
kg8m
force-pushed
the
support-routing-frozen
branch
from
5c7c90a
to
039e04c
Compare
|
Could I convince you to add an unit test/spec for this new option? |
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
kg8m
force-pushed
the
support-routing-frozen
branch
from
5d18b3c
to
86dc2c5
Compare
|
@ctran Best regards. |
ctran
requested changes
Mar 30, 2023
ctran
reviewed
Mar 30, 2023
ctran
approved these changes
Mar 30, 2023
|
@ctran |
matteolc
pushed a commit
to matteolc/annotate_models
that referenced
this pull request
Mar 31, 2023
commit 22ab676 Author: Cuong Tran <ctran@users.noreply.github.com> Date: Thu Mar 30 15:17:37 2023 -0700 chore: remove broken badges from README.md commit 10a7a76 Author: Takumi KAGIYAMA <694547+kg8m@users.noreply.github.com> Date: Fri Mar 31 07:15:07 2023 +0900 Support `--frozen` option for routing annotations (ctran#979) The `--frozen` option previously deal only model annotations. This change will support route annotations as well. --------- Signed-off-by: kg8m <takumi.kagiyama@gmail.com> Co-authored-by: Cuong Tran <ctran@users.noreply.github.com> commit a28fef3 Author: Jim Jowdy <jjowdy@gmail.com> Date: Wed Mar 29 15:09:11 2023 -0700 Fix retrieve_indexes_from_table when indexes is empty and base table does not exist. (ctran#849) Some tables may have a table_name_prefix but no indexes. Previous versions of the code would strip the prefix and look for indexes on the resulting table which likely would not exist. This causes DB errors, at least in MySQL. So now check if the new table exists first before trying to show its indexes. commit 13b532d Author: Cuong Tran <ctran@users.noreply.github.com> Date: Wed Mar 29 01:51:15 2023 -0700 Update codeql-analysis.yml commit ea4cd00 Author: Lovro Bikić <lovro.bikic@infinum.hr> Date: Wed Mar 29 10:31:01 2023 +0200 Add support for annotating check constraints (ctran#868) This adds annotation of check constraints with an option to disable/enable annotation. Most of the work done in this PR is based off of existing implementation for annotating indexes and foreign keys. Signed-off-by: Lovro Bikic <lovro.bikic@infinum.hr> commit 76a1804 Author: Lovro Bikić <lovro.bikic@gmail.com> Date: Wed Mar 29 10:18:24 2023 +0200 Fix flaky specs (ctran#980) Signed-off-by: Lovro Bikic <lovro.bikic@infinum.hr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thanks for this great gem! The
--frozenoption is very useful.I noticed that the
--frozenoption doesn't work for routing annotations (rake annotate_routesandannotate --routes). This pull request adds the support for that.Best regards.