Add position_in_additional_file_patterns to options and parser #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwl
added a commit
to drwl/annotaterb
that referenced
this pull request
May 23, 2023
Changes pulled from ctran/annotate_models#977. Credit goes to @Benjaminpjacobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running annotations on files that match additional file paths the default position is not observed and it will always default to before. Essentially this line resolves to
position_in_additional_file_patternsin this case but the option parser does not account for this case.This PR allows that option to be parsed, set and defaulted so that that files that match additional patterns can have annotations set at the bottom of the file.