Throw ETIMEDOUT on timeout when clarifyTimeoutError is true #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbachmann
approved these changes
Apr 12, 2023
marcbachmann
force-pushed
the
throw-ETIMEDOUT-when-clarifyTimeoutError-true
branch
from
f75b1f8
to
3d4426f
Compare
|
I've rebased. Basically this project doesn't have any optional chaining operator yet. Let's see whether tests succeed. |
The migration to newer syntax should happen in a separate PR.
|
@marcbachmann Are there any plans for when this will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where
timeout()andtimeoutOnce()would throwECONNABORTEDinstead of the correctETIMEDOUT, whentransitional.clarifyTimeoutErrorwas set totrue.Relevant Axios documentation:
Source https://github.com/axios/axios/blob/v1.x/README.md#request-config.
Closes #336.