Use AxiosError constructor to create axios errors if available #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstein
force-pushed
the
axios-error-constructor
branch
from
914444c
to
1d83731
Compare
|
Thanks for this |
|
What is the timeline for this fix? We are currently forced to implement workarounds in our tests. |
|
Tests are failing, I can merge it as soon as they pass. |
|
I might take a gander at fixing the tests tonight, if @rstein isn't around |
|
Hi! I have changed the error creation to use the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From v0.27.2 axios uses a constructor to create instances of AxiosError. (See axios/axios#3645). This PR uses said constructor to create errors and falls back to the previous behavior for older versions if the constructor is not available. This also fixes #338