Package filter conf parser #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parser and evaluator for the fapolicyd filter config
The public api here is not integrated into the system in this PR. A later commit will integrate it as the backend of the editor.
The evaluation function implemented here can be used to enhance the analysis view by tying a trust decision back to a line from rpm filter, similar to how rules are referenced. A difference between rules and trust here is that the trust relation may not exist, where the rule relation always exists.
The impl uses a trie to map characterwise for searching. The impl supports the same wildcard characters as the fapolicyd impl. There is decent test coverage, but likely more corner cases. Configurations from the wild, mapped into tests, would be useful. The examples from the fapolicyd man pages are mapped to tests.
#758