Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black version #1871

Merged
merged 1 commit into from Apr 5, 2022
Merged

Update black version #1871

merged 1 commit into from Apr 5, 2022

Conversation

LukasNickel
Copy link
Member

- Click 8.1 broke black
- Fixed in black 22.3: psf/black#2966
@LukasNickel LukasNickel changed the title Updateblack version Update black version Apr 5, 2022
Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to update, but do we use Click anywhere? It isn't a required dependency at least

@maxnoe
Copy link
Member

maxnoe commented Apr 5, 2022

Black uses it and then the pre-commit hook would fail

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1871 (9bb7d5e) into master (00dfa39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1871   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         187      187           
  Lines       14786    14786           
=======================================
  Hits        13613    13613           
  Misses       1173     1173           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00dfa39...9bb7d5e. Read the comment docs.

@maxnoe maxnoe merged commit 65a3dfe into master Apr 5, 2022
@maxnoe maxnoe deleted the update_black branch April 5, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants