Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postcss-preset-env : more documentation and a few fixes #313

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Mar 19, 2022


Features list

Finally a fixed "address" for the features list and in a format that isn't source code.

It is generated in the same way as we do the site.

https://github.com/csstools/postcss-plugins/blob/postcss-preset-env-some-fixes--philosophical-grey-mouse-lemur-97e4054681/plugin-packs/postcss-preset-env/FEATURES.md

Also added a small hint to the ID on the site :

Screenshot 2022-03-19 at 09 53 34

Quick start

With all the new docs to explain what postcss-preset-env does and how it works we pushed the usage docs down a lot.

This section sits at the top and has the intention of making it feel safe and easy to get going.

https://github.com/csstools/postcss-plugins/tree/postcss-preset-env-some-fixes--philosophical-grey-mouse-lemur-97e4054681/plugin-packs/postcss-preset-env#quick-start

@@ -5,7 +5,7 @@
},
"extends": "eslint:recommended",
"parserOptions": {
"ecmaVersion": 2020,
"ecmaVersion": 2022,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint was nagging about top level async await.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for tackling this!

@Antonio-Laguna Antonio-Laguna merged commit 99a732a into main Mar 19, 2022
@Antonio-Laguna Antonio-Laguna deleted the postcss-preset-env-some-fixes--philosophical-grey-mouse-lemur-97e4054681 branch March 19, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants