add plugin id help for config's #103
Conversation
| @@ -113,14 +115,24 @@ const plugin = opts => { | |||
| const usedPlugins = supportedFeatures.map(feature => feature.plugin); | |||
| usedPlugins.push(stagedAutoprefixer); | |||
|
|
|||
| const internalPlugin = () => { | |||
There was a problem hiding this comment.
This was broken.
It's not possible to have both OnceExit and plugins in the same PostCSS plugin.
These need to be chained.
I do not know the exportsTo plugin so I can't easily add a test for it to double check that everything is fine now.
| $font: system-ui; | ||
|
|
||
| .test-variable { | ||
| font-family: $font; | ||
| font-family: system-ui, -apple-system, Segoe UI, Roboto, Ubuntu, Cantarell, Noto Sans, sans-serif; | ||
| } |
There was a problem hiding this comment.
This change confuses me a bit. Why is this needed?
There was a problem hiding this comment.
It confused me too.
tape contents for this test :
'insert:after:array': {
message: 'supports { stage: 1, after: { "lab-function": [ require("postcss-simple-vars") ] } } usage',
options: {
stage: 1,
insertAfter: {
'lab-function': [
require('postcss-simple-vars')()
]
},
features: {
'lab-function': {
unresolved: 'ignore'
}
}
},
expect: 'insert.after.expect.css'
},I replaced the color-mod stuff with lab-function to resolve the warnings.
I think that insertAfter looks up the index of the plugin (lab-function) and tries to add the other plugin after it.
If the feature is not found I think it was never inserted.
So when color-mod was removed postcss-simple-vars was no longer applied correctly in this test.
Now that I have changed it to lab-function it actually works again.
Although probably not as designed because of plugins not having an order in PostCSS 8
There was a problem hiding this comment.
Hmm we should probably add another issue to test this meaningfully since I don't think this test proves anything right now
| @@ -11,6 +11,10 @@ export function pluginIdHelp(featureNamesInOptions, root, result) { | |||
| const byId = mostSimilar(featureName, featureNames); | |||
| const byPackage = mostSimilar(featureName, packageNames); | |||
|
|
|||
| // TODO : | |||
| // 1. create markdown docs with the plugin id's | |||
There was a problem hiding this comment.
outside of scope of this change.
But I want to already indicate were in the code this can be mentioned to users.
Antonio-Laguna
deleted the
add-plugin-id-help-for-config--empathetic-humpback-whale-326a3ee971
branch
partial fix for : csstools/postcss-preset-env#156
Also see : #86 (reply in thread)
Uses a levenshtein distance to possibly suggest the correct plugin.
Tests failed because we still had some that were using
color-modand this then throw warnings with the new help stuff.Maybe the entire
insertBeforeinsertAfterstuff is outdated since this is no longer of PostCSS plugins run? But this is outside the scope of this change.