Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/postcss 8 #53

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Conversation

devpeerapong
Copy link
Contributor

@devpeerapong devpeerapong commented Mar 19, 2021

This pull request upgrade to postcss@8

The test will fail because the current version of postcss-browser-comments still use postcss@7

should be merged after csstools/postcss-browser-comments#4

Related Issue

postcss-browser-comments csstools/postcss-browser-comments#5
create-react-app cannot upgrade to postcss@8 facebook/create-react-app#9664

@gitKrystan
Copy link

gitKrystan commented Mar 26, 2021

Trying this PR in our app. Ran into this error:

Could not require 'ember-cli-build.js': Cannot find module '...node_modules/postcss-normalize/dist/index.cjs.js'. Please verify that the package.json has a valid "main" entry

I can't be totally sure the error is from this package because there are so many packages that are seemingly having trouble with postcss 8. Here are the relevant parts of our package.json:

{
  "devDependencies": {
    "@csstools/postcss-sass": "jonathantneal/postcss-sass#pull/26/head",
    "ember-cli-postcss": "^7.0.0",
    "postcss": "^8.2.8",
    "postcss-clean": "leodido/postcss-clean#release/2.x",
    "postcss-normalize": "csstools/postcss-normalize#pull/53/head",
    "postcss-scss": "^3.0.5",
    // ...
  },
  "resolutions": {
    "postcss-browser-comments": "csstools/postcss-browser-comments#pull/4/head"
    // ...
  },
}

@devpeerapong
Copy link
Contributor Author

I think this happens because when you specify dependencies via Git Repository.
The package manager (npm or yarn) just download the source code from that repository, which in this case does not contain the build file.

I suggest that you clone the repository, run build locally and npm link or yarn link on both postcss-normalize and postcss-browsers-comment

@await-ovo
Copy link

any updates on this

@radiosilence
Copy link

radiosilence commented Apr 28, 2021

@devpeerapong

I added a fork incase the package was totally dead, but then I realised that they were both owned by @jonathantneal so we'd either have to go further up the chain and fork this package too, or wait for him to merge/release.

Also I think the tests need updating, too.

@jonathantneal
Copy link
Collaborator

Hi @radiosilence, thanks for the ping. I’m hoping I get through my workload well enough today that I can pick this up tonight.

@radiosilence
Copy link

radiosilence commented Apr 29, 2021

@jonathantneal amazing, thanks mate! Just need a version bump on this project really and then I think CRA can update and everything is golden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants