New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent merging of :host(tag) and tag #876
Conversation
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
==========================================
+ Coverage 97.33% 97.33% +<.01%
==========================================
Files 118 118
Lines 3452 3455 +3
Branches 1035 1036 +1
==========================================
+ Hits 3360 3363 +3
Misses 84 84
Partials 8 8
Continue to review full report at Codecov.
|
increasing jest timeout to 30s to fix this and for future changes as well |
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 118 118
Lines 3458 3461 +3
Branches 1040 1041 +1
=======================================
+ Hits 3364 3367 +3
Misses 86 86
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is safe to merge, but not for all cases, it is unsafe for browsers which not supported :host
https://caniuse.com/#search=host%20selector, so we should use browserslist
here to ensure we can merge it or not
I think this fix is not required as we are already checking the compatibility. So I don't think there is a way as of now to test it with the compatibility. We can keep an eye on this list and when they add What do you think |
Okay I guess And I think the |
Closing this as this is already done. Just need to add test, I will add that later once got to know the query for level 1 selectors in |
fixes #730
closes #731