Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss-merge-rules): preserve container queries #1493

Merged
merged 2 commits into from Apr 23, 2023

Conversation

ludofischer
Copy link
Collaborator

@ludofischer ludofischer commented Apr 22, 2023

Add a test for #1489 and ensure container queries do not get merged incorrectly.

Related to #1489, but the code snippet
in that issue is not valid CSS
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fae4813) 97.54% compared to head (9e8da14) 97.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1493   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         123      123           
  Lines       10139    10149   +10     
=======================================
+ Hits         9890     9900   +10     
  Misses        249      249           
Impacted Files Coverage Δ
packages/postcss-merge-rules/src/index.js 97.25% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

For now, bail out if we detect a nested rule or atrule.
Fix #1489
@ludofischer ludofischer changed the title test(postcss-merge-rules): test container queries fix(postcss-merge-rules): preserve container queries Apr 23, 2023
@ludofischer ludofischer merged commit eb9a9a1 into master Apr 23, 2023
16 checks passed
@ludofischer ludofischer deleted the test-container-query branch April 23, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants