fix(postcss-reduce-idents): fix line names grid templates #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludofischer
commented
Apr 22, 2023
| @@ -53,6 +55,19 @@ module.exports = function () { | |||
| } | |||
| }); | |||
| } | |||
| if (child.type === 'word') { | |||
| const word = child.value; | |||
| if (word.startsWith('[') && word.endsWith(']')) { | |||
There was a problem hiding this comment.
Maybe there's a better way to do it, but postcss-value-parser does not understand list of elements in brackets at all.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1491 +/- ##
=======================================
Coverage 97.54% 97.55%
=======================================
Files 123 123
Lines 10149 10189 +40
=======================================
+ Hits 9900 9940 +40
Misses 249 249
☔ View full report in Codecov by Sentry. |
ludofischer
force-pushed
the
update-columns
branch
2 times, most recently
from
0d4e72d
to
4ab09f1
Compare
Handle grid and column names enclosed in square brackets. Cover both the case where the brackets contain a single grid line name and the case where the brackets contain multiple separate grid line names. Fix #529 (again)
ludofischer
force-pushed
the
update-columns
branch
from
4ab09f1
to
74fc574
Compare
|
@alexander-akait do you think we can merge this? |
alexander-akait
approved these changes
Apr 27, 2023
|
I think yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle grid and column names enclosed in square brackets. Cover both the case where the brackets contain a single grid line name and the case where the brackets contain multiple separate grid line names.
Fix #529 (again)