chore: update TypeScript to 5.0.2 #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix case where now TypeScript sees this as void.
ludofischer
force-pushed
the
update-typescript
branch
from
aaa2fa1
to
35c59bf
Compare
ludofischer
changed the title
ludofischer
commented
Mar 16, 2023
| @@ -307,7 +307,7 @@ function partialMerge(first, second) { | |||
|
|
|||
| /** | |||
| * @param {function(import('postcss').Declaration):void} callback | |||
| * @this {import('postcss').Rule} | |||
| * @this void | |||
There was a problem hiding this comment.
Now TypeScript sees it as void. I think it could be right since it's arrow functions all the way, so maybe this never gets bound, but I don't think it matters since this it's never used in the callbacks either.
alexander-akait
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated to 5.0.2 directly since it's been released in the meantime. No changes except one parameter type change.