test: remove Node.js 10 and 12 from CI #1477
Conversation
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1477 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 122 122
Lines 10000 10000
=======================================
Hits 9762 9762
Misses 238 238 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@alexander-akait I think you need to update the required checks on master if we want to get rid of the Node.js 10 and 12 tests because I haven't got access to that setting. |
|
WIP |
|
Done 👍 |
Are you sure you want to make 19 required? Then we'll need to change the settings again in June when it becomes EOL and replaced by 20. |
|
On the one hand, I agree that this is not necessary, on the other hand, we can catch all potential compatibility gaps (to be honest, I don’t think they will, but I have met very different situations), so let's keep it, if we will need to do release rapidly, we can ignore it and merge |
Remove unmaintained Node.js from CI. As we're not testing against Node.js 10 and 12 I think we need to bump the minimal supported Node version on all packages, because we cannot guarantee that we won't introduce an incompatibility in the future.