New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps)!: upgrade svgo to v3 #1440
Conversation
This PR is meant to get work started to support svgo v3 and thus in draft state. I'm not sure what else needs to be done as I'm new to this library's source. Feel free to add or suggest necessary changes. I'm open to improvement suggestions! |
Hi, @dargmuesli Thank you for this PR, I found the questions in the Nuxtjs. When I add some lib on the Nuxt projects, The command line print this warning:
So, If this PR is merged, Can I give a PR to Nuxt.js? Thank you so much! |
Hey @CharleeWa, thank you for your support. Regarding Nuxt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! I think the only issue is that we would need to release a major version of postcss-svgo, cssnano, cssnano-preset-default and cssnano-preset-advanced. Updating to a major version can be inconvenient for those users who install cssnano as a transitive dependency. I've done a quick check :
css-minimizer-webpack-plugin
(4371000 downloads) already requires Node.js 14.15, but the most downloaded version is still the 3.x which only requires Node.js 12.x- Parcel: only requires Node.js 12.x but I think they use lightningcss by default
- vue-cli: Only requires Node.js 12.x, but is deprecated
What do you think @alexander-akait ? Can we drop Node < 14 and release cssnano 6 in the near future? If we release 6 I would at least also get rid of the YAML parser, since it's only necessary for the (udocumented) YAML configuration feature which I think nobody is using (if they do they can just turn it into JSON)
The postcss-svgo tests need to be updated because the result is slightly different but it looks equivalent (different attribute order and minified identifiers) |
@ludofischer I think it is time to drop old nodes, so I am fine with the next v6 |
Sorry, I wasn't specific enough. If you use the pnpm package manager, the installation dependency will have this prompt. Of course it's not a big deal, just a warning, but it doesn't look very comfortable. So, I think we should wait for cssnano to release a new version, nuxt will update cssnano's version, and the problem will not exist. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1440 +/- ##
==========================================
- Coverage 97.62% 97.62% -0.01%
==========================================
Files 122 122
Lines 10010 10007 -3
==========================================
- Hits 9772 9769 -3
Misses 238 238
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Thank you for updating the tests. It might take a bit longer before we release 6.x New cssnano releases take a long time to reach users, so I would like to do at least another 5.x release with the updates we've just merged on master. Maybe it's also possible to solve some merge-rules bugs on 5.x before we switch to 6. |
I updated to v3.0.1 and reverted the |
@dargmuesli can you rebase to solve pnpm merge |
BREAKING CHANGE: increase the minimum supported node version to v14.
Co-authored-by: Ludovico Fischer <43557+ludofischer@users.noreply.github.com>
Rebased as requested ✅ |
When this PR will be merged? |
Bump, when can we merge this PR? @ludofischer |
I'm looking forward to have it merged |
Please upvote the PR by giving a 👍 on the first comment here and do not add "me too" comments, thanks! |
Oh, is is possible to merge it finally and publish on npm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVGO has released a new patch version so the csso types package should no longer be needed.
Considering Node14 is almost out of maintenance schedule, getting this in sooner would be much appreciated. I get moving slow with major updates, but considering users do not have to upgrade unless they want to, doing a major update shouldn't take so long or be so painful. |
@ludofischer Maybe it is time to do major release and drop old nodejs support? |
What features would you want from SVGO 3? There seem to be at least one unsolved regression from SVGO 2: svg/svgo#1746. I don't know how impactful these are though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this.
Summary
Upgrade dependency svgo to v3 and increase the minimum supported node version to v14.
Motivation
Keep up to date with the svgo upstream library.
Does this pull request introduce a breaking change?
Checklist
Documentation
Please check if any of these apply: