Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): remove obsolete build scripts #1145

Merged
merged 1 commit into from Jun 7, 2021
Merged

Conversation

ludofischer
Copy link
Collaborator

  • remove buildPackages script
  • remove scripts used only by buildPackages
  • remove unused dev deps
  • get rid of duplicate fs-extra by updating it to 9.1

buildPackages tries to keep the README by introspecting the code (it even imports the presets!) but right now it makes the docs worse (replaces a lot of plugin description with This plugin is loaded with its default configuration.) I think it's easier to write text by hand than fix this script.

* remove buildPackages script
* remove scripts used only by buildPackages
* remove unused dev deps
* get rid of duplicate fs-extra by updating it to 9.1
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #1145 (212e7ea) into master (b60f54b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files         116      116              
  Lines        3593     3592       -1     
  Branches     1054     1054              
==========================================
- Hits         3465     3464       -1     
  Misses        119      119              
  Partials        9        9              
Impacted Files Coverage Δ
...ckages/postcss-ordered-values/src/rules/columns.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9acd6a2...212e7ea. Read the comment docs.

@alexander-akait
Copy link
Member

Maybe in this case we need write steps how to do release in this case, otherwise somebody from contributors can forget

@ludofischer
Copy link
Collaborator Author

Maybe in this case we need write steps how to do release in this case, otherwise somebody from contributors can forget

I don't think that's necessary. Ihave never used these scripts to do the release because I remember @anikethsaha already told me they were broken, so I don't think anyone is relying on them. They've probably never been updated since lerna was introduced to the repo (the READMEs must have been updated by hand for some time, since running the script destroys some of the information). They're not documented in CONTRIBUTORS.md either.

@alexander-akait
Copy link
Member

hm, how you do release right now (steps)?

@ludofischer
Copy link
Collaborator Author

ludofischer commented Jun 7, 2021

hm, how you do release right now (steps)?

The way it says in CONTRIBUTING.md :-) :

yarn lerna publish from-package

I think buildPackages mainly updated the READMEs. It does not even seem to keep the versions in sync in package.json I've kept the two other scripts buildMetadata and buildSiteMarkdown as they're used to build the website.

@ludofischer ludofischer merged commit 14c76d5 into master Jun 7, 2021
@ludofischer ludofischer deleted the cleanup-scripts branch June 7, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants