chore: use yarn workspaces #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerate integration test to take into account prefix changes.
This package is not imported anywhere and docusaurus handles publishing now.
To prepare removing lerna, keep lerna but enable workspaces. All lerna alternatives (changesets, rush) rely on workspaces. yarn hoists all dependencies to the root node_modules with a single yarn.lock. Install and testing is much faster. The issue with hoisting might cause phantom dependencies (a package is able to import packages not in their own `package.json`).
|
Closing this as I have the impression there are too many bugs with the lerna + Yarn 1 workspaces (also yarn 1 is not being developed any more, so the workspace feature might not see any bug fix). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've discussed, lerna does not work very well for us. The alternatives I have seen rely workspaces.
so move to yarn workspaces to prepare removing lerna completely. We are still using lerna, but with
useWorkspacesoption turned on.Since this recreates the whole dependency tree, it had the effect of bumping Browserslist which caused the integration tests to fail for
cssnano-preset-advanced(also happens on the dependabot PR). So to check whether workspaces themselves break something, I have first updated all dependencies, and then moved to workspaces in separate commits.The problem with workspaces is that since everything is hoisted to the root, a package can import a dependency which is not in its
package.jsonmore easily, but I could not find a solution except switching to pnpm, so I guess we need to be careful if we merge this.