Commits on May 18, 2021

1. feat(postcss-colormin): switch to colord and solve multiple issues …

   * ensure that the replacement color values are shorter than the original. Previously, the plugin returned the converted value without checking whether it was shorter than the original, we now ensure we always return the shortest color value
   * rework the colomin cache so use only one cache as in #771 (without using Ramda as in that PR). The cache key is now just the declaration value. Before there were two caches, one with a CSS `property|value` key and one that cached the single colors.
   * change the underlying library to [colord](https://github.com/omgovich/colord).
   Using `colord` comes with some trade-offs. On the plus side, it automatically rounds up up, which fixes an [open issue](#819) without additional work, reduces transitive dependencies from 5 to 0 (although I think the previous 4 are all maintained by the same people), is smaller and claims to be faster (haven't checked but I suspect css-value-parser is more the bottle neck than color conversion here).
   On the minus side, the `colord` parser is very lenient so it accepts invalid CSS colors (rgb with mixed percentages and numbers) which cssnano did not convert before, so I've added some checks to skip these values. Overall there are less lines of code.
   * get rid of the JSON file with precomputed CSS color names. I guess the idea was that the JSON file only contained color names that are shorter than the hex, but the color conversion libraries include all color names anyway to be able to parse, so in fact we ship the color names twice. I don't think the extra code for generating the file, plus loading the JSON is worth it to avoid a an extra length check.
   
   fix(postcss-colormin): do not replace original value with longer one
   
   fix #1042
   
   feat(postcss-colormin): switch to colord
   
   * round color values fix #819
   * reduce dependencies
   
   perf(postcss-colormin): improve caching
   
   Fix #771
   
   refactor(postcss-colormin): drop the generate script

   

   ludofischer committed May 18, 2021
   Copy the full SHA

   1d36ad1 View commit details

   Browse the repository at this point in the history