fix: merging of un-supported pseudo classes

cssnano · Jun 9, 2020 · 448455a · 448455a
1 parent f326b7f
commit 448455a
Show file tree

Hide file tree

Showing 12 changed files with 32 additions and 17 deletions.
diff --git a/packages/cssnano-preset-advanced/src/__tests__/integrations/bootstrap-v4.2.1.css b/packages/cssnano-preset-advanced/src/__tests__/integrations/bootstrap-v4.2.1.css
diff --git a/packages/cssnano-preset-advanced/src/__tests__/integrations/concise-v4.1.2.css b/packages/cssnano-preset-advanced/src/__tests__/integrations/concise-v4.1.2.css
diff --git a/packages/cssnano-preset-advanced/src/__tests__/integrations/semantic-ui-v2.4.1.css b/packages/cssnano-preset-advanced/src/__tests__/integrations/semantic-ui-v2.4.1.css
diff --git a/packages/cssnano-preset-advanced/src/__tests__/integrations/turret-v5.1.3.css b/packages/cssnano-preset-advanced/src/__tests__/integrations/turret-v5.1.3.css
diff --git a/packages/cssnano-preset-advanced/src/__tests__/integrations/uikit-v3.0.3.css b/packages/cssnano-preset-advanced/src/__tests__/integrations/uikit-v3.0.3.css
diff --git a/packages/cssnano-preset-default/src/__tests__/integrations/bootstrap-v4.2.1.css b/packages/cssnano-preset-default/src/__tests__/integrations/bootstrap-v4.2.1.css
diff --git a/packages/cssnano-preset-default/src/__tests__/integrations/concise-v4.1.2.css b/packages/cssnano-preset-default/src/__tests__/integrations/concise-v4.1.2.css
diff --git a/packages/cssnano-preset-default/src/__tests__/integrations/semantic-ui-v2.4.1.css b/packages/cssnano-preset-default/src/__tests__/integrations/semantic-ui-v2.4.1.css
diff --git a/packages/cssnano-preset-default/src/__tests__/integrations/turret-v5.1.3.css b/packages/cssnano-preset-default/src/__tests__/integrations/turret-v5.1.3.css
diff --git a/packages/cssnano-preset-default/src/__tests__/integrations/uikit-v3.0.3.css b/packages/cssnano-preset-default/src/__tests__/integrations/uikit-v3.0.3.css
diff --git a/packages/postcss-merge-rules/src/__tests__/index.js b/packages/postcss-merge-rules/src/__tests__/index.js
@@ -251,9 +251,20 @@ test(
 
 test(
   'should merge vendor prefixed selectors when vendors are the same',
-  processCSS(
-    'code ::-moz-selection{background:red}code::-moz-selection{background:red}',
-    'code ::-moz-selection,code::-moz-selection{background:red}'
+  passthroughCSS(
+    'code ::-moz-selection{background:red}code::-moz-selection{background:red}'
+  )
+);
+
+test(
+  'should not merge pseudo which are not supported by the browsers ::selection',
+  passthroughCSS('::selection{background:red} ::selection{background:red}')
+);
+
+test(
+  'should not merge pseudo which are not supported by the browsers - code ::selection',
+  passthroughCSS(
+    'code ::selection{background:red} code ::selection{background:red}'
   )
 );
 

diff --git a/packages/postcss-merge-rules/src/lib/ensureCompatibility.js b/packages/postcss-merge-rules/src/lib/ensureCompatibility.js
@@ -1,3 +1,4 @@
+import postcss from 'postcss';
 import { isSupported } from 'caniuse-api';
 import selectorParser from 'postcss-selector-parser';
 
@@ -55,6 +56,7 @@ export const pseudoElements = {
   '::marker': 'css-marker-pseudo',
   '::placeholder': 'css-placeholder',
   '::selection': 'css-selection',
+  ':visited': cssSel3,
 };
 
 function isCssMixin(selector) {
@@ -97,8 +99,10 @@ export default function ensureCompatibility(
       ast.walk((node) => {
         const { type, value } = node;
         if (type === 'pseudo') {
-          const entry = pseudoElements[value];
-          if (entry && compatible) {
+          const entry = pseudoElements[postcss.vendor.unprefixed(value)];
+          if (!entry) {
+            compatible = false;
+          } else if (compatible) {
             compatible = isSupportedCached(entry, browsers);
           }
         }