Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu shadow fix #209

Merged
merged 1 commit into from Oct 27, 2022
Merged

Menu shadow fix #209

merged 1 commit into from Oct 27, 2022

Conversation

csandman
Copy link
Owner

@csandman csandman commented Oct 27, 2022

  • Fix an overflow issue causing MenuList shadow to get cut off - closes [BUG] Menu shadow clipped #208
    • Fix was done by removing overflow: hidden on the Menu component, which, as far as I'm aware, isn't needed for anything anyway
  • In addition, made some other styles for the Menu and MenuList more closely align with the original styles from react-select

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 338472b:

Sandbox Source
chakra-react-select demo Configuration
chakra-react-select TS demo Configuration
chakra-react-select + next.js Configuration
chakra-react-select + next.js + typescript Configuration
eager-microservice-8s0goo Issue #208

@github-actions
Copy link

📊 Package size report   0.4%↑

File Before After
dist/cjs/chakra-components/menu.js 11.0 kB 3%↑11.3 kB
dist/cjs/chakra-components/menu.js.map 19.6 kB 2%↑20.0 kB
dist/esm/chakra-components/menu.js 10.2 kB 3%↑10.5 kB
dist/esm/chakra-components/menu.js.map 19.7 kB 2%↑20.2 kB
Total (Includes all files) 387.9 kB 0.4%↑389.4 kB
Tarball size 65.7 kB 0.6%↑66.1 kB
Unchanged files
File Size
dist/cjs/async-creatable-select.js 2.3 kB
dist/cjs/async-creatable-select.js.map 1.8 kB
dist/cjs/async-select.js 2.3 kB
dist/cjs/async-select.js.map 1.6 kB
dist/cjs/chakra-components/containers.js 3.7 kB
dist/cjs/chakra-components/containers.js.map 6.5 kB
dist/cjs/chakra-components/control.js 9.2 kB
dist/cjs/chakra-components/control.js.map 15.8 kB
dist/cjs/chakra-components/index.js 2.8 kB
dist/cjs/chakra-components/index.js.map 2.2 kB
dist/cjs/chakra-components/input.js 3.3 kB
dist/cjs/chakra-components/input.js.map 4.8 kB
dist/cjs/chakra-components/multi-value.js 6.1 kB
dist/cjs/chakra-components/multi-value.js.map 11.3 kB
dist/cjs/chakra-components/placeholder.js 1.7 kB
dist/cjs/chakra-components/placeholder.js.map 2.6 kB
dist/cjs/chakra-components/single-value.js 1.6 kB
dist/cjs/chakra-components/single-value.js.map 2.4 kB
dist/cjs/creatable-select.js 2.3 kB
dist/cjs/creatable-select.js.map 1.7 kB
dist/cjs/index.js 2.7 kB
dist/cjs/index.js.map 1.5 kB
dist/cjs/module-augmentation.js 61 B
dist/cjs/module-augmentation.js.map 9.3 kB
dist/cjs/select.js 2.2 kB
dist/cjs/select.js.map 1.5 kB
dist/cjs/types.js 47 B
dist/cjs/types.js.map 3.5 kB
dist/cjs/use-chakra-select-props.js 5.9 kB
dist/cjs/use-chakra-select-props.js.map 7.7 kB
dist/cjs/utils.js 1.8 kB
dist/cjs/utils.js.map 2.0 kB
dist/esm/async-creatable-select.js 856 B
dist/esm/async-creatable-select.js.map 1.9 kB
dist/esm/async-select.js 800 B
dist/esm/async-select.js.map 1.7 kB
dist/esm/chakra-components/containers.js 3.3 kB
dist/esm/chakra-components/containers.js.map 6.6 kB
dist/esm/chakra-components/control.js 8.5 kB
dist/esm/chakra-components/control.js.map 15.9 kB
dist/esm/chakra-components/index.js 1.3 kB
dist/esm/chakra-components/index.js.map 2.5 kB
dist/esm/chakra-components/input.js 3.1 kB
dist/esm/chakra-components/input.js.map 4.9 kB
dist/esm/chakra-components/multi-value.js 5.6 kB
dist/esm/chakra-components/multi-value.js.map 11.4 kB
dist/esm/chakra-components/placeholder.js 1.5 kB
dist/esm/chakra-components/placeholder.js.map 2.7 kB
dist/esm/chakra-components/single-value.js 1.3 kB
dist/esm/chakra-components/single-value.js.map 2.5 kB
dist/esm/creatable-select.js 824 B
dist/esm/creatable-select.js.map 1.8 kB
dist/esm/index.js 679 B
dist/esm/index.js.map 1.7 kB
dist/esm/module-augmentation.js 58 B
dist/esm/module-augmentation.js.map 9.3 kB
dist/esm/select.js 768 B
dist/esm/select.js.map 1.6 kB
dist/esm/types.js 44 B
dist/esm/types.js.map 3.5 kB
dist/esm/use-chakra-select-props.js 5.7 kB
dist/esm/use-chakra-select-props.js.map 7.7 kB
dist/esm/utils.js 1.7 kB
dist/esm/utils.js.map 2.0 kB
dist/types/async-creatable-select.d.ts 632 B
dist/types/async-creatable-select.d.ts.map 632 B
dist/types/async-select.d.ts 558 B
dist/types/async-select.d.ts.map 604 B
dist/types/chakra-components/containers.d.ts 704 B
dist/types/chakra-components/containers.d.ts.map 322 B
dist/types/chakra-components/control.d.ts 1.7 kB
dist/types/chakra-components/control.d.ts.map 589 B
dist/types/chakra-components/index.d.ts 5.1 kB
dist/types/chakra-components/index.d.ts.map 208 B
dist/types/chakra-components/input.d.ts 295 B
dist/types/chakra-components/input.d.ts.map 237 B
dist/types/chakra-components/menu.d.ts 1.3 kB
dist/types/chakra-components/menu.d.ts.map 490 B
dist/types/chakra-components/multi-value.d.ts 1.1 kB
dist/types/chakra-components/multi-value.d.ts.map 432 B
dist/types/chakra-components/placeholder.d.ts 325 B
dist/types/chakra-components/placeholder.d.ts.map 252 B
dist/types/chakra-components/single-value.d.ts 326 B
dist/types/chakra-components/single-value.d.ts.map 254 B
dist/types/creatable-select.d.ts 590 B
dist/types/creatable-select.d.ts.map 612 B
dist/types/index.d.ts 1.0 kB
dist/types/index.d.ts.map 833 B
dist/types/module-augmentation.d.ts 9.5 kB
dist/types/module-augmentation.d.ts.map 2.0 kB
dist/types/select.d.ts 480 B
dist/types/select.d.ts.map 552 B
dist/types/types.d.ts 3.3 kB
dist/types/types.d.ts.map 3.3 kB
dist/types/use-chakra-select-props.d.ts 613 B
dist/types/use-chakra-select-props.d.ts.map 255 B
dist/types/utils.d.ts 601 B
dist/types/utils.d.ts.map 212 B
LICENSE.md 1.1 kB
package.json 4.0 kB
README.md 44.5 kB

🤖 This report was automatically generated by pkg-size-action

@csandman csandman merged commit 181ca4f into main Oct 27, 2022
@csandman csandman deleted the menu-overflow-fix branch October 27, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Menu shadow clipped
1 participant