Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: orchestrator cannot build #215

Merged
merged 1 commit into from Mar 6, 2023
Merged

Conversation

thomas-nguy
Copy link
Collaborator

Revert the dependency upgrade #50 because it is breaking the build

@thomas-nguy
Copy link
Collaborator Author

seems that the vulnerability does not affect us

tokio-rs/prost#438

@thomas-nguy thomas-nguy temporarily deployed to CI March 6, 2023 07:55 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 6, 2023 07:55 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 6, 2023 07:55 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 6, 2023 07:55 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy requested a review from tomtau March 6, 2023 07:56
Copy link

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or you can bump all Prost dependencies ? not sure if any of them need manual upgrades?

@thomas-nguy
Copy link
Collaborator Author

yes I've tried to do it but it end up breaking too many things. May give a try later (#216)

@thomas-nguy thomas-nguy merged commit 769c968 into v2.0.0-cronos Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants