Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(credentials): threadlocal credentials are cleared before request processing #1402

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(credentials): threadlocal credentials are cleared before request processing #1402

wants to merge 1 commit into from

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to #1388

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@mergify mergify bot added the safe-to-test label Mar 13, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1402-30843419d60521448ea75e51e69d805bb4c33f3f sh smoketest.sh

@andrewazores andrewazores force-pushed the threadlocal-session-fix branch 2 times, most recently from 3d6f27a to 89b6246 Compare March 13, 2023 22:48
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1402-89b62469de9555717f16cdfe8ed27e0510f7daab sh smoketest.sh

@andrewazores
fix(credentials): threadlocal credentials are cleared before request …
79738cc 
…processing

Signed-off-by: Andrew Azores <aazores@redhat.com>
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1402-79738cc7003dadbc22794c819c07dd902523a80d sh smoketest.sh

@andrewazores andrewazores mentioned this pull request Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix safe-to-test
Projects
No open projects
2.3.0 release
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andrewazores