Upgrade dev env packages. #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 22.42% 22.45% +0.02%
==========================================
Files 268 268
Lines 7549 7548 -1
Branches 1154 1154
==========================================
+ Hits 1693 1695 +2
+ Misses 4780 4777 -3
Partials 1076 1076
Continue to review full report at Codecov.
|
sotarok
commented
Jun 30, 2020
| "eqeqeq": "off", | ||
| "camelcase": "off", |
There was a problem hiding this comment.
We'll fix these offs step by step.
| @@ -93,7 +93,7 @@ export default class CrowiRenderer { | |||
| result = code | |||
| } | |||
|
|
|||
| result = escape ? result : Crowi.escape(result, true) | |||
| result = escaped ? result : Crowi.escape(result, true) | |||
| "typescript": "^3.7.3" | ||
| "ts-jest": "^26.1.1", | ||
| "ts-node": "^8.10.2", | ||
| "typescript": "^3.8.3" |
There was a problem hiding this comment.
Upgraded typescript not to 3.9 but 3.8, because of webpack/webpack/issues/10227
lightnet328
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade: