Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: default host for events should always be production #1120

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

alaisgomes
Copy link
Contributor

Ticket

PLAT-XXXX
Related tickets:
Related PRs:

Type of PR

  • Bugfix
  • New feature
  • Minor changes

Did you make changes to modules or created a new module?

Changes introduced

Amplitude events are never being sent to production because the comparison between the host value (compared to the default host) was off one character (/)

Test and review

Set host to production URL
Notice SEGMENT_API_KEY being the production key, not staging

@alaisgomes alaisgomes merged commit 48fec5d into develop Apr 1, 2024
4 checks passed
@alaisgomes alaisgomes deleted the hotfix/segment-prod-host branch April 1, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants