Lint with same go version as build #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
reviewed
Apr 20, 2021
| # This action uses its own setup-go, which always seems to use the latest | ||
| # stable version of Go. We could run 'make lint' to ensure our desired Go | ||
| # version, but we prefer this action because it leaves 'annotations' (i.e. | ||
| # it comments on PRs to point out linter violations). |
There was a problem hiding this comment.
Is the part of this comment that was removed no longer true, or was I mistaken when I wrote it?
There was a problem hiding this comment.
@negz it is still true, but we are now disabling it with skip-go-installation: true (which I just added).
There was a problem hiding this comment.
Ah, got it. It seems like that option didn't exist back when I wrote this comment (it was added inhttps://github.com/golangci/golangci-lint-action/pull/144).
Updates lint workflow to setup go version beforehand so that it uses the same as all build and publish workflows. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
lint-with-go-version
branch
from
73bbbdd
to
3932247
Compare
negz
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates lint workflow to setup go version beforehand so that it uses the
same as all build and publish workflows.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
n/a