Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channel: Do not cache thread id on aarch64 linux #836

Closed
wants to merge 1 commit into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 22, 2022

From #802 (comment)

For the record, taking 0.5.4 works, and changing try_select to have #[inline(never)] breaks it again.

Given that an annotation about inlining reintroduces the issue, it appears that this may also be reintroduced by options such as opt-level and LTO.

Disabling cache on aarch64 linux until the problem is fixed upstream is probably a more robust approach.

@taiki-e
Copy link
Member Author

taiki-e commented May 22, 2022

cc @glandium

@taiki-e taiki-e force-pushed the taiki-e/aarch64-current-thread-id branch from 24136fd to dcbea2a Compare May 22, 2022 07:58
@taiki-e taiki-e changed the title Do not cache thread id on aarch64 linux channel: Do not cache thread id on aarch64 linux May 22, 2022
@taiki-e
Copy link
Member Author

taiki-e commented Jul 22, 2022

The current one seems to be working anyway, so will close this for now.

@taiki-e taiki-e closed this Jul 22, 2022
@taiki-e taiki-e deleted the taiki-e/aarch64-current-thread-id branch July 22, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant