Use AtomicU64 for head/tail index in deque, channel, and queues #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Jan 23, 2022
Comment on lines
+64
to
+91
| #[cfg(not(crossbeam_no_atomic_64))] | ||
| pub(crate) use core::sync::atomic::AtomicU64; | ||
|
|
||
| #[cfg(crossbeam_no_atomic_64)] | ||
| #[derive(Debug)] | ||
| #[repr(transparent)] | ||
| pub(crate) struct AtomicU64 { | ||
| inner: crossbeam_utils::atomic::AtomicCell<u64>, | ||
| } | ||
|
|
||
| #[cfg(crossbeam_no_atomic_64)] | ||
| impl AtomicU64 { | ||
| pub(crate) const fn new(v: u64) -> Self { | ||
| Self { | ||
| inner: crossbeam_utils::atomic::AtomicCell::new(v), | ||
| } | ||
| } | ||
| pub(crate) fn load(&self, _order: Ordering) -> u64 { | ||
| self.inner.load() | ||
| } |
There was a problem hiding this comment.
Is it preferable to define this in crossbeam_utils::atomic?
taiki-e
force-pushed
the
atomic-64
branch
2 times, most recently
from
9f4f0c1
to
2a94555
Compare
taiki-e
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #433.