Add block cache to SegQueue-alikes #746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iriri
force-pushed
the
extremely-questionable
branch
from
60ffaa3
to
c943bae
Compare
… time, add questionable alloc benchmark
iriri
force-pushed
the
extremely-questionable
branch
from
c943bae
to
c60c5b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some early discussion and rough benchmarks can be found in #398.
The imprecision of the block cache operations is intentional and seems to be a key part of making this work. As mentioned in #398 (comment), it is very easy for a cache/junkyard to be counterproductive in the average case so I prioritized reducing contention over trying to reuse a block in every possible case. All of my attempts to increase the accuracy of the operations, such as by CAS-ing against null in
try_putrather than blindly swapping, have resulted in worse benchmark performance. I have also not seen a positive effect so far from adjusting the size of the block cache in either direction.This needs more benchmarking, including on architectures other than x86-64.