Add a ping-pong benchmark to crossbeam-channel #492
+126
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping-pong is an important benchmark since it measure latency characteristics of the transport as opposed to plain throughput characteristics. In addition, it also is a decent test of the empty-channel read cost
|
While I'm sure it's possible, it wasn't actually clear how to do a clean ping-pong benchmark with the futures channels so I haven't added one yet. I also didn't update the benchmark png since I have a different machine, and don't necessarily want to push a totally new set of baseline numbers. The generated one is here: https://i.imgur.com/O9b9CLx.png |
|
@taiki-e any reason this wasn't merged? |
|
This is a more complete version of what I wrote for demonstrating #821. I think having it as an official benchmark to measure performance of is valuable. |
|
Sorry for the late response. I've read the first half of the #492 (comment) and assumed this was a WIP state. Otherwise, I think adding such a benchmark is fine. |
taiki-e
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping-pong is an important benchmark since it measure latency
characteristics of the transport as opposed to plain throughput
characteristics. In addition, it also is a decent test of the
empty-channel read cost