Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure on nightly and the minimum version #428

Merged
merged 7 commits into from Oct 16, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 15, 2019

target_has_atomic = "cas" was removed in rust-lang/rust#65214.

Fixes rust-lang/rust#65424
Fixes #412

@jeehoonkang
Copy link
Contributor

Thanks!

bors r+

bors bot added a commit that referenced this pull request Oct 15, 2019
428: Fix breakage with nightly feature r=jeehoonkang a=taiki-e

`target_has_atomic = "cas"` was removed in rust-lang/rust#65214.

Fixes rust-lang/rust#65424 



Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 15, 2019

Build failed

bors bot added a commit that referenced this pull request Oct 15, 2019
429: Limit lazy_static version r=jeehoonkang a=jeehoonkang

Closes #412 

It's necessary to accept #428, which is fixing a breakage of Rust ecosystems...

Co-authored-by: Jeehoon Kang <jeehoon.kang@kaist.ac.kr>
@taiki-e
Copy link
Member Author

taiki-e commented Oct 15, 2019

@jeehoonkang Since the build on Rust 1.26 is broken, I think we need to merge this and #429 at the same time.

@jeehoonkang
Copy link
Contributor

Thanks for updating the dependency.

bors r+

bors bot added a commit that referenced this pull request Oct 15, 2019
428: Fix breakage with nightly feature r=jeehoonkang a=taiki-e

`target_has_atomic = "cas"` was removed in rust-lang/rust#65214.

Fixes rust-lang/rust#65424 
Fixes #412


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@jeehoonkang
Copy link
Contributor

CI fails with permission error: https://travis-ci.org/crossbeam-rs/crossbeam/jobs/598198019#L203

@jeehoonkang
Copy link
Contributor

jeehoonkang commented Oct 15, 2019

Thinking again, downgrading only for CI looks suspicious. Then CI can only tell a modified Crossbeam (with different dependency) compiles for Rust 1.26, but not Crossbeam as-is. I think it may not be what we want... Do you know how Rayon deals with such a situation?

@bors
Copy link
Contributor

bors bot commented Oct 15, 2019

Build failed

@taiki-e
Copy link
Member Author

taiki-e commented Oct 15, 2019

Thinking again, downgrading only for CI looks suspicious. Then CI can only tell a modified Crossbeam (with different dependency) compiles for Rust 1.26, but not Crossbeam as-is. I think it may not be what we want... Do you know how Rayon deals with such a situation?

I think the following comments accurately explain the current situation (using an old Cargo.lock):

rayon-rs/rayon#586 (comment)

The state of the ecosystem is that, for better or worse, any less-than-latest Rust version is not supported in general, and in practice absolutely unusable without an old Cargo.lock. Debian's Rust is just totally useless.

Also, they recently bumped the minimum version to 1.28 (rayon-rs/rayon#675), so I think we can drop 1.26 and 1.27's support.

Edit: see rayon-rs/rfcs#3 for rayon's a minimum Rust policy

@taiki-e taiki-e force-pushed the nightly branch 4 times, most recently from a897f73 to ee23853 Compare October 15, 2019 15:48
@taiki-e
Copy link
Member Author

taiki-e commented Oct 15, 2019

@jeehoonkang CI passed.

@jeehoonkang
Copy link
Contributor

I'm fine with this change, I'd like to wait for another approval because it's changing the CI policy. @Vtec234 @stjepang Any thoughts?

@ghost
Copy link

ghost commented Oct 16, 2019

Let's drop support for 1.26 and 1.27.

@taiki-e taiki-e changed the title Fix breakage with nightly feature Fix build failure on nightly and the minimum version Oct 16, 2019
@taiki-e
Copy link
Member Author

taiki-e commented Oct 16, 2019

Added commit to drop support for 1.26 and 1.27. Also, since the minimum version is 1.28, we can revert #393 and fix bare_trait_objects warnings.

@taiki-e
Copy link
Member Author

taiki-e commented Oct 16, 2019

Oh... deprecated warnings...

error: use of deprecated item 'std::mem::uninitialized': use `mem::MaybeUninit` instead
  --> crossbeam-epoch/src/deferred.rs:39:38
   |
39 |                 let mut data: Data = mem::uninitialized();
   |                                      ^^^^^^^^^^^^^^^^^^
   |
   = note: `-D deprecated` implied by `-D warnings`

I will use #[allow(deprecated)] because the alternative requires 1.36.

@jeehoonkang
Copy link
Contributor

Thanks!

bors retry

bors bot added a commit that referenced this pull request Oct 16, 2019
428: Fix build failure on nightly and the minimum version r=jeehoonkang a=taiki-e

`target_has_atomic = "cas"` was removed in rust-lang/rust#65214.

Fixes rust-lang/rust#65424 
Fixes #412


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 16, 2019

Build failed

@jeehoonkang
Copy link
Contributor

bors retry

bors bot added a commit that referenced this pull request Oct 16, 2019
428: Fix build failure on nightly and the minimum version r=jeehoonkang a=taiki-e

`target_has_atomic = "cas"` was removed in rust-lang/rust#65214.

Fixes rust-lang/rust#65424 
Fixes #412


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 16, 2019

Build succeeded

@bors bors bot merged commit 35dc824 into crossbeam-rs:master Oct 16, 2019
@taiki-e taiki-e deleted the nightly branch October 16, 2019 14:15
@taiki-e taiki-e mentioned this pull request May 3, 2020
@jonhoo jonhoo mentioned this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants