Updating dependencies #2091

oberstet · 2023-08-23T17:17:27Z

No description provided.

oberstet · 2023-08-23T18:29:03Z

unfortunately, the CI is broken (well, not running at all) because of #2092

The imp module is deprecated since Python 3.4 [1]. The import was added even after it was deprecated in [2]. In Python 3.12 the imp module will be removed. Use the reload function from importlib, which is the designated replacement [1]. With crossbario#2091 and this change, crossbar can be installed and run on Python 3.12 with: - numpy>=1.26.0b1 - wsaccel @ git+https://github.com/methane/wsaccel@v0.6.4 (assuming cython>=3.0.0 is installed, tarball from pypi won't work [3]) [1] https://docs.python.org/3.11/library/imp.html [2] crossbario@21910b0 [3] methane/wsaccel#30

The imp module is deprecated since Python 3.4 [1]. The import was added even after it was deprecated in [2]. In Python 3.12 the imp module will be removed. Use the reload function from importlib, which is the designated replacement [1]. With #2091 and this change, crossbar can be installed and run on Python 3.12 with: - numpy>=1.26.0b1 - wsaccel @ git+https://github.com/methane/wsaccel@v0.6.4 (assuming cython>=3.0.0 is installed, tarball from pypi won't work [3]) [1] https://docs.python.org/3.11/library/imp.html [2] 21910b0 [3] methane/wsaccel#30

Bastian-Krause · 2023-11-20T16:24:44Z

As predicted in #2093: With wsaccel 0.6.6, numpy 1.26.0 and aiohttp 3.9.0 being released, this PR is the last thing needed for crossbar Python 3.12 compatibility. Any chance to get this merged soon?

By the way, I need to specify eth-utils<2.3.0 to make crossbar work (unrelated to Python 3.12) . Otherwise I see:

  Traceback (most recent call last):
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/bin/crossbar", line 5, in <module>
      from crossbar import run
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/crossbar/__init__.py", line 19, in <module>
      import eth_abi
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/__init__.py", line 15, in <module>
      from eth_abi.abi import (  # NOQA
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/abi.py", line 1, in <module>
      from eth_abi.codec import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/codec.py", line 12, in <module>
      from eth_abi.decoding import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/decoding.py", line 8, in <module>
      from eth_utils import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_utils/__init__.py", line 86, in <module>
      from .network import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_utils/network.py", line 7, in <module>
      from eth_typing import ChainId
  ImportError: cannot import name 'ChainId' from 'eth_typing' (/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_typing/__init__.py)

Bastian-Krause · 2023-12-11T11:50:33Z

Ping?

oberstet · 2023-12-11T13:55:12Z

@Bastian-Krause yeah, fair enough, it should really be fixed. I mean the CI overall, and this specifically as well. personally, I won't have time soon, as my focus is on stuff that earns me money, sorry! classical OSS destiny;) if commercial users (and I'm not talking about you or your org) are using it (I know for a fact of publicly listed companies that do), they should pay for support and community, or provide fixes / PRs, or use something else. it's a free world .. pun;)

side note: btw, I did apply at https://www.sovereigntechfund.de/, which first moved on, but then failed as I am apparently better at code than forms, and I am not inclined to waste a life on burocracy;) anyways, just saying.

crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. Since this is the last remaining issue before we can advertise Python 3.12 support, let's mark these tests as XFAIL for now. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <basti@randomprojects.de>

crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. We shouldn't advertise Python 3.12 support until that happens. But we can make sure that everything else keeps working fine with Python 3.12 by running the test suite. A previous commit marked the failing crossbar tests as XFAIL for 3.12. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <bst@pengutronix.de>

crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. Since this is the last remaining issue before we can advertise Python 3.12 support, let's mark these tests as XFAIL for now. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <basti@randomprojects.de>

crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. We shouldn't advertise Python 3.12 support until that happens. But we can make sure that everything else keeps working fine with Python 3.12 by running the test suite. A previous commit marked the failing crossbar tests as XFAIL for 3.12. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <bst@pengutronix.de>

crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. Since this is the last remaining issue before we can advertise Python 3.12 support, let's mark these tests as XFAIL for now. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <bst@pengutronix.de>

crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. We shouldn't advertise Python 3.12 support until that happens. But we can make sure that everything else keeps working fine with Python 3.12 by running the test suite. A previous commit marked the failing crossbar tests as XFAIL for 3.12. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <bst@pengutronix.de>

David Ellis and others added 2 commits March 31, 2023 13:40

- Updated eth-abi to use 4.0.0 instead of beta version

a6274cd

use latest release of eth-abi published 08.06.23

507726e

oberstet mentioned this pull request Aug 23, 2023

Updated eth-abi to use 4.0.0 instead of beta version #2070

Closed

Bastian-Krause mentioned this pull request Aug 24, 2023

common/reloader: import reload from importlib (Python 3.12 compatibility) #2093

Merged

Bastian-Krause mentioned this pull request Aug 24, 2023

Python 3.12 compatibility labgrid-project/labgrid#1260

Draft

9 tasks

DZabavchik mentioned this pull request Sep 1, 2023

RLink fixes and enhancements #2095

Open

Merge branch 'master' into updating_dependencies

9e0924b

Bastian-Krause mentioned this pull request Dec 13, 2023

Test with Python 3.12, but don't advertise it, yet labgrid-project/labgrid#1306

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating dependencies #2091

Updating dependencies #2091

oberstet commented Aug 23, 2023 •

edited

oberstet commented Aug 23, 2023

Bastian-Krause commented Nov 20, 2023

Bastian-Krause commented Dec 11, 2023

oberstet commented Dec 11, 2023 •

edited

Updating dependencies #2091

Are you sure you want to change the base?

Updating dependencies #2091

Conversation

oberstet commented Aug 23, 2023 • edited

oberstet commented Aug 23, 2023

Bastian-Krause commented Nov 20, 2023

Bastian-Krause commented Dec 11, 2023

oberstet commented Dec 11, 2023 • edited

oberstet commented Aug 23, 2023 •

edited

oberstet commented Dec 11, 2023 •

edited