Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we always have publisher/caller information #1778

Merged
merged 3 commits into from Jun 17, 2020

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Jun 12, 2020

See also crossbario/autobahn-python#1393 (which is needed to make this work).

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #1778 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
+ Coverage   32.25%   32.27%   +0.01%     
==========================================
  Files          81       81              
  Lines       13919    13936      +17     
  Branches     2465     2466       +1     
==========================================
+ Hits         4490     4498       +8     
- Misses       9037     9048      +11     
+ Partials      392      390       -2     
Impacted Files Coverage Δ
crossbar/worker/rlink.py 18.30% <20.00%> (+0.54%) ⬆️
crossbar/router/broker.py 28.77% <100.00%> (+0.14%) ⬆️
crossbar/router/dealer.py 35.43% <100.00%> (+0.10%) ⬆️
crossbar/webservice/base.py 29.10% <0.00%> (-0.21%) ⬇️
crossbar/bridge/mqtt/wamp.py 30.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f79f4...1dd666f. Read the comment docs.

@oberstet
Copy link
Contributor

so this is just a stop-gap "solution", until we have rectified crossbario/autobahn-python#1392, right?

because all of sessionid, authid and authrole MUST (well, should, because of of above unfixed issue) always be available to rlinks

@meejah meejah changed the title authid can be None ensure we always have publisher/caller information Jun 16, 2020
@oberstet oberstet merged commit 9bec9d3 into crossbario:master Jun 17, 2020
@meejah meejah deleted the rlink-fixups branch June 17, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants