Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WAMP message internal-only attributes for publisher/caller disclosure #1392

Closed
oberstet opened this issue Jun 11, 2020 · 4 comments
Closed
Assignees

Comments

@oberstet
Copy link
Contributor

oberstet commented Jun 11, 2020

from https://crossbario.slack.com/archives/C0473JCQ6/p1591287619078900

would work like this:

IOW, like:

Event._internal_only_publisher
Event._internal_only_publisher_authid
Event._internal_only_publisher_authrole
Call._internal_only_caller
Call._internal_only_caller_authid
Call._internal_only_caller_authrole

we can probably do that generically, for any WAMP message sent/received in Message https://github.com/crossbario/autobahn-python/blob/master/autobahn/wamp/message.py#L362

@oberstet
Copy link
Contributor Author

background:

  • rlinks (for router-to-router) need to have the original publisher/caller to fill in forward_for
  • since rlinks sit as regular, but router-embedded sessions on the originating realm, they only currently get access to this information if the realm was configured to disclose the publisher/caller

above provides the basis to work around this limitation in CB.

@meejah
Copy link
Contributor

meejah commented Jun 16, 2020

We could just add _router_internal (or similar) to Message -- and thus assign anything at all that the router wants.

@oberstet
Copy link
Contributor Author

^ yeah, agreed! that looks cleaner (only 1 attribute, and having flexibility rgd what we stick to that ..)

@meejah
Copy link
Contributor

meejah commented Jul 20, 2020

This is fixed in #1393

@meejah meejah closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants