Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly prefer -ar to -gcc-ar. #1105

Merged
merged 1 commit into from Nov 1, 2022
Merged

Explicitly prefer -ar to -gcc-ar. #1105

merged 1 commit into from Nov 1, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Fixes #1100.

@Alexhuszagh Alexhuszagh added bug container-images A-bsd Area: BSD-family targets A-newlib Area: newlib targets A-solaris Area: solaris targets labels Nov 1, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner November 1, 2022 14:27
@Alexhuszagh
Copy link
Contributor Author

bors try --target -none- --target *-freebsd --target *-dragonfly --target *-solaris --target *-illumos *-netbsd

bors bot added a commit that referenced this pull request Nov 1, 2022
@bors
Try #1105: --target *-none-* --target *-freebsd --target *-dragonfly …
b13b037 
…--target *-solaris --target *-illumos *-netbsd
@Alexhuszagh Alexhuszagh mentioned this pull request Nov 1, 2022
Merged
@Alexhuszagh
Copy link
Contributor Author

Note I didn't provide AR_$target for the Android images, since these are provided in #1023.

@bors
Copy link
Contributor

bors bot commented Nov 1, 2022

try

Build succeeded:

Emilgardis
Emilgardis approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is parallel to rust-lang/cc-rs#741, but this is fine standalone and resolves issues for people locked to cc="=1.0.74"

bors r+

bors bot added a commit that referenced this pull request Nov 1, 2022
@bors @Alexhuszagh
Merge #1105
9779929 
1105: Explicitly prefer `-ar` to `-gcc-ar`. r=Emilgardis a=Alexhuszagh

Fixes #1100.

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 1, 2022

Build succeeded:

@bors bors bot merged commit 1d72f53 into cross-rs:main Nov 1, 2022
@Alexhuszagh Alexhuszagh deleted the gcc_ar branch November 1, 2022 18:00
@svenstaro
Copy link
Contributor

Can we get a release containing this? Otherwise this is currently broken by default.

@Alexhuszagh
Copy link
Contributor Author

I don't think 0.3.0 is quite ready for release, especially not in the next week or so, but this is a trivial patch so we could backport it and do a quick release for 0.2.5?

@Emilgardis
Copy link
Member

cc 1.0.75 has been released. rust-lang/cc-rs#741 (comment)

hopefully this solves the problem enough

@Emilgardis Emilgardis added this to the v0.3.0 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
A-bsd Area: BSD-family targets A-newlib Area: newlib targets A-solaris Area: solaris targets bug container-images
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

archiver in freebsd images appears to be broken
3 participants
@Alexhuszagh @svenstaro @Emilgardis