Allow *_config timeout to be specified as an env var/args.

[yjszk]

@aflanagan @shaneharter

If the number of monitors exceeds 150, the following error occurs in validate_config and apply_config.

requests.exceptions.ConnectionError: HTTPSConnectionPool(host='cronitor.io', port=443): Max retries exceeded with url: /api/monitors.yaml (Caused by ReadTimeoutError("HTTPSConnectionPool(host='cronitor.io', port=443): Read timed out. (read timeout=10)"))

The timeout value is fixed to 10 seconds inside the library and we wanted to be able to set it with env var/args.

[aflanagan]

Hi @yjszk thank you for the update! And apologies, I miscommunicated something in my last email. I was hoping that we could set it up to work from either an env var OR from the passed in argument as you had written it before. Some users like to configure everything from env vars, but many are just running the commands a couple of times locally and don't want the extra overhead. Possible to support both?

[yjszk]

Hi @yjszk thank you for the update! And apologies, I miscommunicated something in my last email. I was hoping that we could set it up to work from either an env var OR from the passed in argument as you had written it before. Some users like to configure everything from env vars, but many are just running the commands a couple of times locally and don't want the extra overhead. Possible to support both?

@aflanagan
I tried to support both. Environment variables are prioritised.
I had another problem while testing.I've created a separate pull request. Please use when it is good. thank you!
#29
#30

[aflanagan]

This is great!

One simplifying change I would like to consider (and am open to feedback on), is to simply set
timeout here, and then read that internally in the _put and as_yaml methods instead of passing timeout as an arg to the various *_config methods.

I know this isn't quite what I had suggest before, but it would simplify the code and the interface a little bit.

import cronitor
cronitor.timeout = 30
cronitor.apply_config()

internally the timeout attribute would just be set as, but could still be set directly on the module as done in the above example.

timeout = os.getenv('CRONITOR_TIMEOUT', 10)

[yjszk]

Thanks for the review! i have made the code shorter and easier to read.
And README has also been updated. Please check!

a452913